Skip to content

Conversation

@ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Documents coverage of initiate in test_configure_pattern_burst_sites and corrects api usage
  • Adds test test_commit
  • Adds test test_initiate_context_manager_and_wait_until_done
    • Covers context manager for initiate
    • Covers wait_until_done
    • Covers is_done
  • Adds test test_abort
  • Adds test test_abort_keep_alive

List issues fixed by this Pull Request below, if any.

What testing has been done?

Ran the system tests on a system with ni-digital 19.0.1 installed.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #1432 into master will decrease coverage by 4.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
- Coverage   96.14%   91.90%   -4.25%     
==========================================
  Files          10       20      +10     
  Lines        1686     3642    +1956     
==========================================
+ Hits         1621     3347    +1726     
- Misses         65      295     +230     
Flag Coverage Δ
#codegenunittests 88.24% <ø> (?)
#nifakeunittests 96.36% <ø> (ø)
#nimodinstunittests 95.37% <ø> (ø)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
build/helper/metadata_add_all.py 81.35% <0.00%> (ø)
build/helper/__init__.py 100.00% <0.00%> (ø)
build/helper/helper.py 88.28% <0.00%> (ø)
build/helper/codegen_helper.py 92.44% <0.00%> (ø)
build/helper/documentation_snippets.py 90.80% <0.00%> (ø)
build/helper/metadata_filters.py 78.16% <0.00%> (ø)
build/helper/documentation_helper.py 89.42% <0.00%> (ø)
build/helper/metadata_find.py 90.00% <0.00%> (ø)
build/helper/metadata_merge_dicts.py 89.01% <0.00%> (ø)
build/helper/parameter_usage_options.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397d605...85afa76. Read the comment docs.

@sbethur sbethur merged commit 6cd2bd1 into ni:master Apr 27, 2020
@ni-jfitzger ni-jfitzger deleted the nidigital/test_low_level_actions branch April 27, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants