Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Apr 25, 2020

- [ ] I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Add a converter for converting seconds in float to timedelta.

List issues fixed by this Pull Request below, if any.

Required for fixing #1397

What testing has been done?

Added new unit tests. Tests will be run by CI.

@sbethur sbethur requested a review from marcoskirsch April 25, 2020 17:14
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #1434 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   91.90%   91.92%   +0.02%     
==========================================
  Files          20       20              
  Lines        3642     3655      +13     
==========================================
+ Hits         3347     3360      +13     
  Misses        295      295              
Flag Coverage Δ
#codegenunittests 88.24% <ø> (ø)
#nifakeunittests 96.40% <100.00%> (+0.03%) ⬆️
#nimodinstunittests 95.37% <ø> (ø)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
generated/nifake/nifake/_converters.py 96.67% <100.00%> (+0.06%) ⬆️
generated/nifake/nifake/session.py 97.69% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896c33b...3c3c27c. Read the comment docs.

@marcoskirsch marcoskirsch merged commit 0571cd8 into master Apr 27, 2020
@marcoskirsch marcoskirsch deleted the add_seconds_to_timedelta_converter branch April 27, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants