Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Apr 27, 2020

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Change return type of get_time_set_period and get_time_set_edge to datetime.timedelta.

List issues fixed by this Pull Request below, if any.

Partial fix for Issue 1397

What testing has been done?

Tests have been updated as required. CI will run the tests.

@sbethur sbethur requested a review from marcoskirsch April 27, 2020 21:28
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1437 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1437      +/-   ##
==========================================
- Coverage   91.92%   91.85%   -0.08%     
==========================================
  Files          20       22       +2     
  Lines        3655     4433     +778     
==========================================
+ Hits         3360     4072     +712     
- Misses        295      361      +66     
Flag Coverage Δ
#codegenunittests 88.24% <ø> (ø)
#nidigitalsystemtests 91.51% <ø> (?)
#nifakeunittests 96.40% <ø> (ø)
#nimodinstunittests 95.37% <ø> (ø)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
...digital/nidigital/history_ram_cycle_information.py 100.00% <0.00%> (ø)
generated/nidigital/nidigital/_library.py 91.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0571cd8...d6295cf. Read the comment docs.

@marcoskirsch
Copy link
Member

#1397 says hightime.TimeDelta. This PR uses datetime.TimeDelta.
This shouldn't close #1397 just yet, right?

@sbethur
Copy link
Contributor Author

sbethur commented Apr 29, 2020

#1397 says hightime.TimeDelta. This PR uses datetime.TimeDelta.
This shouldn't close #1397 just yet, right?

That's right, I updated the PR description to prevent auto-linking to 1397.

@marcoskirsch marcoskirsch merged commit ce6e5e9 into master Apr 29, 2020
@marcoskirsch marcoskirsch deleted the bug1397/nidigital_get_time_set_returns_timedelta branch April 29, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants