Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Apr 27, 2020

- [ ] I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Add test for channels repeated capability
  • Add test for sites repeated capability
  • Add test for sites/pins chained repeated capability

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Added new tests. CI will run the tests.

- Add test for channels repeated capability
- Add test for sites repeated capability
- Add test for sites/pins chained repeated capability
@sbethur sbethur requested a review from marcoskirsch April 27, 2020 23:12
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1439   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          20       20           
  Lines        3657     3657           
=======================================
  Hits         3362     3362           
  Misses        295      295           
Flag Coverage Δ
#codegenunittests 88.25% <ø> (ø)
#nifakeunittests 96.40% <ø> (ø)
#nimodinstunittests 95.37% <ø> (ø)
#nitclkunittests 95.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4b836...4a987e3. Read the comment docs.

@sbethur sbethur merged commit b7b7a3c into master Apr 29, 2020
@sbethur sbethur deleted the nidigital_channels_sites_rep_caps_tests branch April 29, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants