Skip to content

Conversation

@ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds nidigital system test test_close
  • Adds nidigital system test test_get_fail_count
  • Adds nidigital system test test_send_software_edge_trigger

List issues fixed by this Pull Request below, if any.

What testing has been done?

Ran nidigital system tests on a system with nidigital 19.0.1 installed.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #1441 into master will increase coverage by 1.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   91.92%   93.28%   +1.35%     
==========================================
  Files          20       23       +3     
  Lines        3655     5016    +1361     
==========================================
+ Hits         3360     4679    +1319     
- Misses        295      337      +42     
Flag Coverage Δ
#codegenunittests 88.24% <ø> (ø)
#nidigitalsystemtests 96.91% <ø> (?)
#nifakeunittests 96.40% <ø> (ø)
#nifgensystemtests 96.91% <ø> (?)
#nimodinstunittests 95.37% <ø> (ø)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
...digital/nidigital/history_ram_cycle_information.py 100.00% <0.00%> (ø)
generated/nidigital/nidigital/_library.py 96.77% <0.00%> (ø)
generated/nifgen/nifgen/_library.py 96.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d27237...ffde598. Read the comment docs.

@sbethur
Copy link
Contributor

sbethur commented Apr 28, 2020

test this please

1 similar comment
@sbethur
Copy link
Contributor

sbethur commented Apr 28, 2020

test this please

@sbethur sbethur merged commit 7c4b836 into ni:master Apr 29, 2020
@ni-jfitzger ni-jfitzger deleted the nidigital/remaining_system_tests branch April 29, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants