Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented May 14, 2020

- [ ] I've updated CHANGELOG.md if applicable.

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

flake8 on TravisCI got updated recently from 3.7.9 to 3.8.1. On the new version, checks for '...'.format(...) have become stricter.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

CI will run tests.

flake8 on TravisCI got updated recently from 3.7.9 to 3.8.1. On the new version, checks for `'...'.format(...)` has become stricter.
@sbethur sbethur requested a review from marcoskirsch May 14, 2020 21:28
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #1450 into master will not change coverage.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          20       20           
  Lines        3657     3657           
=======================================
  Hits         3362     3362           
  Misses        295      295           
Flag Coverage Δ
#codegenunittests 88.25% <92.30%> (ø)
#nifakeunittests 96.40% <ø> (ø)
#nimodinstunittests 95.37% <ø> (ø)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
build/helper/codegen_helper.py 92.44% <87.50%> (ø)
build/helper/documentation_helper.py 89.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32cba1...e03e647. Read the comment docs.

@marcoskirsch marcoskirsch merged commit 45393c7 into master May 14, 2020
@marcoskirsch marcoskirsch deleted the fix_flake8_violations branch May 14, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants