Create a Vector python type with unit tests. #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Contributor
mjohanse-emr
commented
Jul 25, 2025
bkeryan
requested changes
Jul 25, 2025
bkeryan
reviewed
Jul 25, 2025
mikeprosserni
approved these changes
Jul 28, 2025
bkeryan
reviewed
Jul 28, 2025
bkeryan
reviewed
Jul 28, 2025
added 4 commits
July 29, 2025 14:49
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
jfriedri-ni
requested changes
Jul 29, 2025
Collaborator
jfriedri-ni
left a comment
jfriedri-ni
left a comment
There was a problem hiding this comment.
It looks like we have a few remaining behavior decisions to make.
…ack. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
1 task
jfriedri-ni
approved these changes
Jul 30, 2025
csjall
approved these changes
Jul 30, 2025
bkeryan
requested changes
Jul 30, 2025
…e match checks in set_item. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Vectorclass that is similar to theScalarclass except it contains a list of values along with units and attributes.Vectorclass subclassesMutableSequence.Vectorclass.Why should this Pull Request be merged?
Implements AB#3209791
What testing has been done?
Unit tests, mypy, pyright, styleguide