-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Milestone
Description
At least some of the write flavors don't validate their input
- Unsupported frames are silently dropped
- Wrong number of frames or signals might error or might silently corrupt the data
Areas impact:
nixnet.convertnixnet._session.signals- `nixnet._session.frames
Suggestion: where possible, add a "verify=Trueparameter towrite` functions. When enabled, it will perform checks to make sure the parameters are correct if the driver won't do them itself. Its optional to allow performance critical applications to remove these checks from their inner loop
Unsupported frames: unsolved
Inspiration: nidaqmx's Writer.verify_array_shape.
How this breaks compatibility: If an invalid array was being passed in, the application will now error instead of silently fail. Should not impact most users.
Reactions are currently unavailable