Skip to content

feat(state): Report general and CAN session state#131

Merged
epage merged 4 commits intoni:masterfrom
epage:state
Jul 25, 2017
Merged

feat(state): Report general and CAN session state#131
epage merged 4 commits intoni:masterfrom
epage:state

Conversation

@epage
Copy link
Contributor

@epage epage commented Jul 24, 2017

There are two controversial parts of this

  • If the interface isn't communication, time_start and time_communicating
    throw an error rather than return 0.
  • Each state property will treat fault like any other return code,
    raising an exception or warning, when these properties are accessed

Standard checklist

  • This contribution adheres to CONTRIBUTING.md.
  • New tests have been created for any new features or regression tests for bugfixes.
  • tox successfully runs, including unit tests and style checks (see CONTRIBUTING.md).

@epage epage requested a review from lilesj July 24, 2017 19:49
@epage epage force-pushed the state branch 2 times, most recently from f978b9e to b4ff4e1 Compare July 24, 2017 23:30
@coveralls
Copy link

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-0.1%) to 63.413% when pulling b4ff4e1 on epage:state into 427739f on ni:master.

@epage epage force-pushed the state branch 2 times, most recently from 67b69cd to 93acd1b Compare July 24, 2017 23:48
@epage epage changed the title feat(state): Report general session state feat(state): Report general and CAN session state Jul 24, 2017
@coveralls
Copy link

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-0.1%) to 63.427% when pulling 67b69cd on epage:state into 427739f on ni:master.

@coveralls
Copy link

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-0.1%) to 63.433% when pulling 93acd1b on epage:state into 427739f on ni:master.

@epage epage force-pushed the state branch 2 times, most recently from 812caf9 to 08c3d76 Compare July 25, 2017 15:25
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 63.428% when pulling 812caf9 on epage:state into 068181e on ni:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage decreased (-0.1%) to 63.428% when pulling 812caf9 on epage:state into 068181e on ni:master.

@epage
Copy link
Contributor Author

epage commented Jul 25, 2017

Originally, each state property would call check_for_error on the fault. After talking with Christian, I switched to an explicit check_fault function.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 63.428% when pulling 08c3d76 on epage:state into 068181e on ni:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage decreased (-0.1%) to 63.428% when pulling 08c3d76 on epage:state into 068181e on ni:master.

epage added 2 commits July 25, 2017 10:31
This includes
- time_current
- time_start
- time_communicating
- session info state

Plus an explicit check_fault function.

There are two controverial parts of this
- If the interface isn't communication, time_start and time_communicating
  throw an error rather than return 0.
- Each state property will ignore "fault".  Instead you need to explicitly
  call `check_fault`.
@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage decreased (-0.1%) to 63.428% when pulling 8dd8624 on epage:state into 068181e on ni:master.

@epage epage merged commit 6544598 into ni:master Jul 25, 2017
@epage epage deleted the state branch July 25, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants