feat(state): Report general and CAN session state#131
Merged
Conversation
f978b9e to
b4ff4e1
Compare
67b69cd to
93acd1b
Compare
812caf9 to
08c3d76
Compare
1 similar comment
Contributor
Author
|
Originally, each state property would call |
1 similar comment
This includes - time_current - time_start - time_communicating - session info state Plus an explicit check_fault function. There are two controverial parts of this - If the interface isn't communication, time_start and time_communicating throw an error rather than return 0. - Each state property will ignore "fault". Instead you need to explicitly call `check_fault`.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two controversial parts of this
throw an error rather than return 0.
faultlike any other return code,raising an exception or warning, when these properties are accessed
Standard checklist
toxsuccessfully runs, including unit tests and style checks (see CONTRIBUTING.md).