Skip to content

feat(API): Make add_alias's default_baud_rate optional. #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jashnani merged 1 commit into from
Apr 4, 2018
Merged

feat(API): Make add_alias's default_baud_rate optional. #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions nixnet/system/_databases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ def items(self):
for alias, filepath in self._get_database_list(''):
yield alias, self._create_item(alias, filepath)

def add_alias(self, database_alias, database_filepath, default_baud_rate):
# type: (typing.Text, typing.Text, int) -> None
def add_alias(self, database_alias, database_filepath, default_baud_rate=None):
# type: (typing.Text, typing.Text, typing.Optional[int]) -> None
"""Add a new alias with baud rate size of up to 64 bits to a database file.

NI-XNET uses alias names for database files. The alias names provide a
Expand All @@ -130,6 +130,9 @@ def add_alias(self, database_alias, database_filepath, default_baud_rate):
LDF database formats require a valid baud rate for every
cluster, and NI-XNET uses that baud rate as the default.
"""
if default_baud_rate is None:
default_baud_rate = 0

_funcs.nxdb_add_alias64(database_alias, database_filepath, default_baud_rate)

def _create_item(self, database_alias, database_filepath):
Expand Down