feat(API): Specced out for can_frame_stream_input#31
Merged
Conversation
epage
changed the title
epage
force-pushed
the
loopback
branch
2 times, most recently
from
294ab81 to
4d762e0
Compare
This is a preliminary look at the API sufficient to write the can_frame_stream_input example. This serves as a stepping stone towards completeing ni#22 / ni#23. Some areas of risk - One `Session` type or one per-mode? - Which module parts of the API go into? - Impracticalities of implementing LV-like high level API on top of the C API (like READ_ALL_AVAILABLE). Closes ni#27
epage
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toxsuccessfully runs, including unit tests and style checks (see CONTRIBUTING.md).What does this Pull Request accomplish?
Ports an NI-XNET example over along with proposing enough of an API design for that example.
Some areas of risk
Sessiontype or one per-mode?API (like READ_ALL_AVAILABLE).
Why should this Pull Request be merged?
This serves as a stepping stone towards fleshing out the API (see #22 / #23).
Closes #27