feat(API): Add all non-sub properties to Session#45
Merged
Conversation
This should cover all enums except `intf_flex_ray` properties.
jashnani
approved these changes
Jun 27, 2017
This was referenced Jun 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toxsuccessfully runs, including unit tests and style checks (see CONTRIBUTING.md).intf_flex_rayenum propertiesWhat does this Pull Request accomplish?
Adds all remaining (non-sub) properties to Session.
The properties convert to/from enums where applicable except for
intf_flex_rayproperties. I skipped those for now. I'll create an issue once this is submitted for us to handle those. I noticed #44 while doing this process.Ref properties are not converted at this time. I have an action item to create an issue for us to resolve those.
For now, write-only properties were left as functions. I have an action item to create an issue for us to resolve those.
This PR does not try to get fancy with sub-objects like the DAQmx API. That will come in a separate PR where we can play with what it is that is appropriate for XNET.
Why should this PR be merged?
This is a step towards resolving #23.
What testing has been done?
None