Conversation
This adds properties to `Database` and all sub-objects. In addition, database `save` and cluster `merge` are included. Further database organization is being deferred.
Some future work - `Frame` pdu properties are parallel arrays that should return `namedtuple`s - There isn't an enum for `Ecu.lin_protocol_ver` - `flex_ray` enums are skipped again, see ni#47. - `Frames.ca_nio_mode` is incorrect.
14 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toxsuccessfully runs, including unit tests and style checks (see CONTRIBUTING.md).Framepdu properties are parallel arrays that should returnnamedtuples, seeFrame.pdu_*properties should be considered for a tuple #53Ecu.lin_protocol_ver, seeEcu.lin_protocol_vershould return an enum #54flex_rayenums are skipped again, likeSession.intf_flex_rayproperties return raw values, not enums Ref Objs, etc #47. See Databaseflex_rayproperties aren't using enums #55Frames.ca_nio_modeis incorrect. SeeFrames.ca_nio_modehas weird word-splitting #56What does this Pull Request accomplish?
This adds properties to
Databaseand all sub-objects.In addition, database
saveand clustermergeare included. Furtherdatabase organization is being deferred.
Why should this Pull Request be merged?
This is a step to #9.
What testing has been done?
None