analyze-project: Fix venv caching #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixonjoel
approved these changes
Sep 24, 2025
…dd-common-workflows
dixonjoel
added a commit
that referenced
this pull request
Sep 24, 2025
* Add check_analyzers as a trial balloon
* Fix project-directory inputs, change name of .yml file. Update install-drivers to install-extras
* Rename to analyze-project.yml and 'extras'
* Remove bandit checks. Will be covered by ni-python-styleguide soon
* Switch to a composite action
* Add test for analyze-project
* Create project to analyze
* Add shell specification for actions
* Attempt to fix the project directory for analyze test
* Attempt to fix the project directory for analyze test
* Produce poetry.lock before analyzing
* Add dependency on ni-python-styleguide
* Use a compatible Python version
* Use matrix Python version
* Another attempt at the correct python version
* Tenth time is the charm
* Eleventh time is the charm
* Twelfth time is the charm
* Thirteenth time is the charm
* Try try again
* Try try again
* Add docstrings to .py files
* Try try again
* Whee! Let's try Python
* Add mypy dependency
* Further restrict the Python version for mypy to work
* Show pyproject.toml after the addition of deps
* Attempt to use a template project for testing
* Add mypy section
* Add pyright dependencies
* Update poetry .lock
* Try different working directory
* Try original working directory
* Attempt to make it work on Windows
* Test more Python versions
* Make mypy and pyright optional.
* fix yml syntax
* Indent python code
* Check the outputs
* Check packages after install
* Use GITHUB_OUTPUT
* Move minimal test project under .github to hide it
* Simplify Add virtualenv to the path for pyright-action
* Various PR feedback
* Use poetry env info --path to get the venv path
* Add -C parameter to poetry env --info command
* Attempt to use {{ github.workspace }} instead of ./
* Attempt to use working-directory instead of -C <path>
* Remove stray quote
* Try quoting
* Remove some bash code to narrow down error
* Add back in path
* Try another arrangement
* Try without echoing the path
* Try some quotes, why not?
* Try without --path, why not
* Try without Python 3.9
* Echo the poetry env info
* Add back in path
* Try a different arrangement of quotes
* Change variable name
* Change variable name
* print some debug info
* don't stop on help
* don't fail fast
* ok, let's print it out without exiting first
* ok, use or
* ok, try this...
* analyze-project: Fix venv caching (#28)
* analyze-project: Fix venv caching
* analyze-project: Update prints
---------
Co-authored-by: Joel Dixon <38357562+dixonjoel@users.noreply.github.com>
* Restore all the matrix of python versions and OSs
* Fix copy and paste error in test_actions.yml
* Minor PR feedback
* Remove 3.13t Python from some spots
* Use v0 for actions in README
---------
Co-authored-by: mshafer-NI <23644905+mshafer-NI@users.noreply.github.com>
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Use
poetry env activatebefore querying the path.Why should this Pull Request be merged?
Make venv caching work
What testing has been done?
Manually ran workflow.