Astropy module #3
Conversation
beam_test.py
Outdated
| if i >= args.maxhits: break | ||
|
|
||
| if astro.hits_present(): # Checks if hits are present | ||
| time.sleep(.1) # this is probably not needed, will ask Nick |
…ch - no changes to testconfig
…tead. Mask can still be updated in the code with enable_pixel, enable_inj_row, etc. Removed some functionality by not allowing these input txt files at all.
|
[AS] @nic-str I (Amanda) have incorporated all of these updates to this branch. Please look over it when you get a chance and hopefully early next week (and before you incorporate large changes again) we can finally merge. Enhancements to consider AFTER merge:
|
|
Do we still need these separate mask files with the yaml config files? Also there are a lot of scripts included as well as instrument control classes, which are not really related to the astropy module. Then there is still the issue with a lot of duplicate functions, copied from other modules, in the astropy class. Can this be solved? I would also like to create a separate folder for astropy and call it e.g. "chips/astropy2.py", because it's really specific to v2. Then we could rename the modules folder to something like "core". The modules folder could then be used for extensions like the hitplotter, which are cool but not always necessarly needed. |
|
(from Amanda) I left the python run scripts because I intended for them to be examples from which people could branch off and write their own. I considered moving them to an I also didn't add a greater |
|
@nic-str Just checking in on the status of this request. Are we close to merging? The final action is yours |
…le - do not pass as numpy objects
|
@nic-str Can we take any motion on this merge? If you prefer and think that it is mature enough, we can migrate this code to the shared AstroPix collaboration space and begin developing the shared code base instead of fully merging here. Then we would all utilize / develop in the AstroPix space |
… with AS optimization illustrated in comments. config_c0_r0 activates pixel c0r0 and utilizes all optimized DACs identified by AS
… over full array. Update astropix.py to allow injection enabling outside of asic_init [AS[
…ip with beam_test.py. Will need updates to other example scripts to match path structure and check advanced functionality but baseline running works
|
[Amanda] @nic-str I have incorporated your updates so we should be good to go! I am content now to merge and migrate if you are willing to initiate by approving the merge. I think there is still some cleaning to be done in the collaboration space but since I don't fully understand the structure there yet it may be easiest to merge and migrate and then file paths can be updated. A reminder that I will be on holiday until Dec. 26 and then infrequently at work until Jan. 3. I would like to have the collaboration space finalized and ready to share with our collaborators by Jan. 16 |
5 participants
Astropy is a module which simplifies working with and programing the sensor.
This is not ready to be merged since it hasn't been fully tested on known good hardware yet and there are still some files which need removed/changed.