Skip to content
This repository was archived by the owner on Feb 27, 2019. It is now read-only.

Added Speech auth #205

Open
marcelgoya wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Speech auth #205

marcelgoya wants to merge 2 commits into from

Conversation

@marcelgoya
Copy link

@marcelgoya marcelgoya commented Oct 19, 2016 •
edited by bre7
Loading

Edit:

Closes #181

@bre7
Copy link
Collaborator

bre7 commented Oct 19, 2016 •
edited
Loading

Looks great 👍 Not sure if it will be merged before #194 is fixed

@marcelgoya
Copy link
Author

marcelgoya commented Oct 19, 2016

Thanks 😀 No problem at all. I'm just not 100% sure if some of the translations are correct because I was using GTranslate ...

@nickoneill
Copy link
Owner

nickoneill commented Oct 19, 2016

Thanks! Definitely working on #194 first but this is appreciated. I didn't realize how many language files we've gathered over the last few years...

@marcelgoya
Copy link
Author

marcelgoya commented Oct 19, 2016

Cool! It's not much really :)

@bre7
Copy link
Collaborator

bre7 commented Oct 19, 2016

Could you add a note in the readme (https://github.com/nickoneill/PermissionScope#extra-requirements-for-permissions section) about NSSpeechRecognitionUsageDescription ?

@marcelgoya
Copy link
Author

marcelgoya commented Oct 19, 2016

Sure, will do it later on today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcelgoya @bre7 @nickoneill