fix: change hooks component description and fix typos#27
Open
einatnielsen wants to merge 1 commit into
Open
Conversation
einatnielsen
requested review from
MatanBorenkraoutNielsen,
liadShiranNielsen and
lidoravitan
Contributor
|
Yeah that's a good point :) |
MatanBorenkraoutNielsen
approved these changes
Dec 22, 2019
lidoravitan
approved these changes
Dec 22, 2019
Contributor
lidoravitan
left a comment
lidoravitan
left a comment
There was a problem hiding this comment.
very good point! LGTM!
liadShiranNielsen
approved these changes
Dec 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's better to avoid "time phrases" in readmes like recently , lately, etc. because who knows, someone might encounter this in a few years, read this and might get confused because he never used class components so he doesn't understand why this note is there... so I changed it to:
"Prior to hooks, we were used to writing class components"
This wouldn't need to be changed after a "while" has passed.
WDYT?
also I fixes some typos in this PR