-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Labels
P1: highImportant fix or feature — next up after criticalImportant fix or feature — next up after criticalbugSomething isn't workingSomething isn't working
Description
Description
When the orchestrator launches jobs as part of a plan, it hardcodes the execution mode to 'vanilla', ignoring the user's omo.defaultMode configuration. Users who have configured omo.defaultMode: "ulw" or "ralph" get vanilla mode for all plan jobs.
Steps to Reproduce
- Configure
omo.defaultMode: "ulw"in Mission Control config. - Create a plan:
mc_plan(name: "test", jobs: [...]) - Observe that all spawned jobs run in vanilla mode, not ULW.
Expected Behavior
Plan jobs should respect omo.defaultMode from the config, matching the behavior of direct mc_launch calls.
Actual Behavior
// src/lib/orchestrator.ts:709
mode: 'vanilla',The mode is hardcoded in launchJob() within the orchestrator.
Proposed Fix
Read this.config.omo?.defaultMode and use it as the mode when launching plan jobs:
mode: this.config.omo?.defaultMode ?? 'vanilla',Also consider allowing per-job mode overrides in the JobSpec schema.
Files Involved
src/lib/orchestrator.ts:709— hardcodedmode: 'vanilla'src/lib/config.ts— config definition withomo.defaultMode
Additional Context
Identified in the master audit report (Section 7: Robustness, Section 9: Phase 2 roadmap).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1: highImportant fix or feature — next up after criticalImportant fix or feature — next up after criticalbugSomething isn't workingSomething isn't working