Added Scrape builder and extended provided data#2
Merged
nightbloos merged 1 commit intomasterfrom Sep 11, 2020
Merged
Conversation
vhbit
reviewed
Sep 11, 2020
| } | ||
|
|
||
| func (scraper *Scraper) GetDocument() (*Document, error) { | ||
| doc, err := scraper.getDocument() |
There was a problem hiding this comment.
is it required to have this error dance in here or we can just return scraper.getDocument()?
| } | ||
|
|
||
| func (scraper *Scraper) ParseDocument(doc *Document) (*Document, error) { | ||
| err := scraper.parseDocument(doc) |
There was a problem hiding this comment.
same here, maybe return scraper.parseDocument will be an easier way to handle it?
| scrapeSettings scrapeSettings | ||
| } | ||
|
|
||
| func (b *scrapeBuilder) GetScraper() (*Scraper, error) { |
There was a problem hiding this comment.
I don't know what is more common in go land - to have GetXXX from XXXBuilder or to have a generic Build, please check in other libraries
Owner
Author
There was a problem hiding this comment.
In some places find that is more used Build.
nightbloos
force-pushed
the
support-response-header
branch
from
8a505d9 to
4f9c0d7
Compare
…o 2 different functions `GetDocument` and `ParseDocument`
nightbloos
force-pushed
the
support-response-header
branch
from
4f9c0d7 to
18337da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.