Pump common abstract layer extensions#4529
Conversation
andyrozman
commented
Feb 5, 2026
andyrozman
commented
- added new classes for pump common and extend PumpPluginAbstract class and all classes using it (Medtronic only atm)
…ss and all classes usings it (Medtronic only atm)
pump/common/build.gradle.kts
Outdated
| implementation(project(":core:interfaces")) | ||
| implementation(project(":core:utils")) | ||
| implementation(project(":core:ui")) | ||
| implementation(project(":implementation")) |
There was a problem hiding this comment.
this is wrong. implementation module is the highest level, which should not be included anywhere.
it would slow down compilation significantly.
use interfaces instead
There was a problem hiding this comment.
Removed and refactored the code
| return getOperationNotSupportedWithCustomText(R.string.pump_operation_not_supported_by_pump_driver) | ||
| } | ||
|
|
||
| fun getJSONStatus(profile: Profile, profileName: String, version: String): JSONObject { |
There was a problem hiding this comment.
this has been generalized over all Pump plugins
| } | ||
|
|
||
| // FIXME i18n, null checks: iob, TDD | ||
| fun shortStatus(veryShort: Boolean): String { |
There was a problem hiding this comment.
this has been generalized over all pump plugins
- removed dependency and refactored code that needed it
|
All problems fixed... |
|
|
||
| fun prerequisitesCheck(activity: AppCompatActivity): Boolean | ||
|
|
||
| fun prerequisitesCheck(activity: AppCompatActivity, additionalPermissions: List<String>?): Boolean |
There was a problem hiding this comment.
let's do fun prerequisitesCheck(activity: AppCompatActivity, additionalPermissions: List<String>? = null): Boolean
and have only one function
|
|
Fixed |
2 participants
