PHP 7.1+ support #177
Merged
PHP 7.1+ support #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7.1, PhpUnit 7.5, proper PSR-4 autoloadingAllowing them to fail because they're still being developed.
Removing values that unnecessary and invalid items.
lcobucci
approved these changes
May 30, 2019
Collaborator
lcobucci
left a comment
lcobucci
left a comment
There was a problem hiding this comment.
@codemasher thanks a lot for your contribution.
I've edited your branch a bit to remove the group aliasing and the method chaining. The former is to make things more explicit and the latter is to not modify the API way too much in the same PR that has already many improvements.
Collaborator
Contributor
Author
|
Thank you for the merge! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, i'd like to merge the following:
voidmethods inRouteCollector