Check for subsequent sample_prof_start calls #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no check for `g->enabled` neither in the `sample_prof_start`. As a result, subsequent calls to `sample_prof_start`may result in Segmentation fault (one thread is cancelled only, and another is trying to access memory freed in shutdown function). PS. My internal perfectionist could not ignore this. I apologize for distracting you with such an unnecessary (in most cases) patch.
nikic
reviewed
May 12, 2020
"thelessification" Co-authored-by: Nikita Popov <nikita.ppv@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no check for
g->enabledneither in thesample_prof_start. As a result, subsequent calls tosample_prof_startmay result in Segmentation fault (one thread is cancelled only, and another is trying to access memory freed in shutdown function).PS. My internal perfectionist could not ignore this. I apologize for distracting you with such an unnecessary (in most cases) patch.