Skip to content

feat(service): Zulip Service integration #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
saisumith770 wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat(service): Zulip Service integration #711

saisumith770 wants to merge 20 commits into from

Conversation

@saisumith770
Copy link

@saisumith770 saisumith770 commented Oct 5, 2023

Description

Adds Zulip service to the package

Motivation and Context

solving the issue #457

How Has This Been Tested?

All exported methods have been unit tested with testify.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@saisumith770
feat: zulip client to send messages via bot email and bot api key
d345625
@saisumith770
fix: validations for topic and content
1139977
@saisumith770
refactor: extracted all errors into errors.go
47c8d53
@saisumith770
test(message): added tests for message validation
df62055
@saisumith770
doc(validation): added comments for the validations
5abae06
@saisumith770
feat(hooks): hooks for configuring the client
6f44263
@saisumith770
test(hooks): added tests for all hooks
3527f9c
@saisumith770
Merge branch 'nikoksr:main' into zulip-integration
2f2b9dd
@saisumith770
refactor(test): cleaned up the assert messages
4620583
@saisumith770
ci: nits
3fbaa9c
@saisumith770
test(client): added tests for all client methods
4797ca3
@saisumith770
Merge branch 'zulip-integration' of https://github.com/saisumith770/n…
df8b1bb 
…otify into zulip-integration
@saisumith770
ci: fix linting issue
9fcff13
@saisumith770
test: changed assert to require as per repo testing rules
34003d1
@saisumith770
feat(service): added wrapper for zulip client
a0c958e
@saisumith770
test(service): testing zulip wrapper
3e3e738
@saisumith770
ci: linting nits
45d3cf5
@saisumith770
doc: added docs as per repo style
68c236a
@saisumith770
doc: updated README
fba8d3b
@saisumith770 saisumith770 mentioned this pull request Oct 5, 2023
Open
@saisumith770 saisumith770 changed the title Zulip Service integration feat(service): Zulip Service integration Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saisumith770