Security: Insecure deserialization via torch.load on LoRA checkpoint#217
Open
tuanaiseo wants to merge 1 commit intonikopueringer:mainfrom
Open
Conversation
`torch.load(checkpoint)` is used to load a `.pt` file constructed from an external path. PyTorch checkpoint loading uses pickle semantics and can execute arbitrary code when loading malicious files. If an attacker can influence `pretrained_model_name_or_path_or_dict` or checkpoint contents, this can become code execution. Affected files: pipeline_gvm.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
torch.load(checkpoint)is used to load a.ptfile constructed from an external path. PyTorch checkpoint loading uses pickle semantics and can execute arbitrary code when loading malicious files. If an attacker can influencepretrained_model_name_or_path_or_dictor checkpoint contents, this can become code execution.Severity:
highFile:
gvm_core/gvm/pipelines/pipeline_gvm.pySolution
Avoid pickle-based loading for untrusted files. Prefer
safetensorsfor weights. If using PyTorch >=2.0+, usetorch.load(..., weights_only=True)where compatible, and strictly validate/allowlist checkpoint locations.Changes
gvm_core/gvm/pipelines/pipeline_gvm.py(modified)Testing