Make VkNonDispatchableHandle uint64 and bring back vkPreload#5
Open
oakes wants to merge 2 commits intonimgl:masterfrom
Open
Make VkNonDispatchableHandle uint64 and bring back vkPreload#5oakes wants to merge 2 commits intonimgl:masterfrom
oakes wants to merge 2 commits intonimgl:masterfrom
Conversation
oakes
changed the title
Contributor
Author
|
@lmariscal this PR should fix this issue: nimgl/nimgl#72 The vulkan triangle test is currently broken because I'm guessing vulkan.nim was regenerated based on an old commit because those things re-appeared when I ran |
Contributor
Author
|
BTW, running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes nimgl/nimgl#70 and regenerates vulkan.nim, fixing the incorrect regeneration from this commit: 091ff99