Skip to content

All annotations are useful#14

Merged
f3l1x merged 1 commit intoninjify:masterfrom
mabar:patch-1
Jul 16, 2018
Merged

All annotations are useful#14
f3l1x merged 1 commit intoninjify:masterfrom
mabar:patch-1

Conversation

@mabar
Copy link
Copy Markdown
Contributor

@mabar mabar commented Jul 15, 2018 •
edited
Loading

With this change will be comments with only doctrine annotations no more reported as useless.

Currently is reported:

/**
 * @Path("/users")
 * @Method("GET")
 */

Currently is NOT reported:

/**
 * Practically the same
 * @Path("/users")
 * @Method("GET")
 */

@mabar
All annotations are useful
7d18a67 
With this change will be comments with only doctrine annotations no more reported as useless.

Currently is reported:
```
	/**
	 * @path("/users")
	 * @method("GET")
	 */
```

Currently is *NOT* reported:
```
	/**
	 * Practically the same
	 * @path("/users")
	 * @method("GET")
	 */
```
@f3l1x f3l1x merged commit 5b827f9 into ninjify:master Jul 16, 2018
@f3l1x
Copy link
Copy Markdown
Contributor

f3l1x commented Jul 16, 2018

Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mabar @f3l1x