Skip to content

Exclude useless sniffs#15

Merged
f3l1x merged 3 commits intoninjify:masterfrom
mabar:master
Aug 28, 2018
Merged

Exclude useless sniffs#15
f3l1x merged 3 commits intoninjify:masterfrom
mabar:master

Conversation

@mabar
Copy link
Copy Markdown
Contributor

@mabar mabar commented Aug 28, 2018

ClosureNotStatic

  • requires all closures defined as static function(){}

UnusedParameter

  • ignores inheritance - reports unused parameters literally everywhere

NewWithoutParentheses

  • colliding with NewWithParentheses

UselessParenthesses

  • not always useless
    • sometimes are used for readability improvement
    • in some complicated cases removal breaks code

NoComma

  • colliding with MissingTrailingComma

@f3l1x f3l1x merged commit c14ff92 into ninjify:master Aug 28, 2018
@f3l1x
Copy link
Copy Markdown
Contributor

f3l1x commented Aug 28, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants