[ENH]: Implement get_spm_globals function body#17
Open
RDoerfel wants to merge 2 commits intonipraxis:mainfrom
Open
[ENH]: Implement get_spm_globals function body#17RDoerfel wants to merge 2 commits intonipraxis:mainfrom
RDoerfel wants to merge 2 commits intonipraxis:mainfrom
Conversation
oesteban
reviewed
Aug 29, 2022
oesteban
left a comment
oesteban
left a comment
There was a problem hiding this comment.
Outstanding!
Your PR has an "enhancement" label indicating that a new feature is proposed and the description of the PR tells why and how this was done. Great job!
I left a comment anticipating the use of this function on a wider context.
…it about the return type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the function body of
get_spm_globalsfunction to load an 4D image for a given filename and compute global spm stats for each volume in the 4D array.