Fixed the spm-funcs python file for the Homework.#28
Open
emmanuellebeau wants to merge 1 commit intonipraxis:mainfrom
Open
Fixed the spm-funcs python file for the Homework.#28emmanuellebeau wants to merge 1 commit intonipraxis:mainfrom
emmanuellebeau wants to merge 1 commit intonipraxis:mainfrom
Conversation
Sorry being late, was very buse the last two weeks.
Contributor
matthew-brett
left a comment
matthew-brett
left a comment
There was a problem hiding this comment.
Sorry I only came back to this now. Just a little comment.
| for i in range(data.shape[-1]): | ||
| spm_vals.append(spm_global(data[..., i])) | ||
|
|
||
| return spm_vals # Return the result. |
Contributor
There was a problem hiding this comment.
Just a small point - the docstring says this should be an array, but you've returned a list here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry being late, was very busy the last two weeks.