Open
Conversation
Revised model with relationships corrected
Author
|
@nissimsan I have corrected some relationships and more of the model is generated in JSON schema, however not convinced its right, I cross checked the SI and feel its similar some key things missing from the schema to be useful once generated. |
nissimsan
approved these changes
Aug 17, 2020
Owner
|
@cmsdroff, I (finally!) got around to look at your PR. The changes look perfect from a commit perspective. But unfortunately I'm not able to open the .mdj file in StarUML. Could you please try to see if the file (still) works on your machine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @nissimsan
Thanks for time earlier, as promised a PR to include the VERMAS or VGM format, some questions for review !
I've approached from a perspective/use case of sending to the port or terminal, if being sent via a software platform or other there maybe other fields that make it in their message guides and in some cases a deviation from the SMDG published standard under UN/CEFACT, so trying not to be influenced by this currently as I know why they are there and they are not really needed.
Look forward to your thoughts, please comment and I'll review and revise before doing another PR.
Much appreciated!