fix behavior when updating values where the value was previously null #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the contribution. |
Contributor
Author
|
@anidotnet when are you planning to release this fix? |
Contributor
|
I'll publish the snapshot version by today and release version possibly by this month end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When trying to update nested documents, if the value was previously null, a NPE was raised. This was because the code inside
NitriteDocument::mergewasn't null checking the value after taking it out of the map.Fix
Added a null check. If the value returned from
getisnull, I assumed we should follow the default behavior and just replace it with whatever was provided by the method. If not, we then usemerge. While fixing this bug I noticed that there's no unit tests forNitriteDocument::mergebut they are covered indirectly via theCollectionUpdateTest. I added a new test case to the existing suite.The code works but I'm up for comments - I'm not sure about the full implications of doing this fix so LMK if there's something I should fix or do differently :)