Skip to content

fix: correctly polyfill globalThis.crypto#3402

Merged
pi0 merged 2 commits intonitrojs:mainfrom
huseeiin:main
Jun 13, 2025
Merged

fix: correctly polyfill globalThis.crypto#3402
pi0 merged 2 commits intonitrojs:mainfrom
huseeiin:main

Conversation

@huseeiin
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@huseeiin huseeiin requested a review from pi0 as a code owner June 11, 2025 16:30
@pi0 pi0 changed the title fix node web crypto polyfill fix: correctly polyfill globalThis.crypto Jun 13, 2025
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

Small tip: Always search for pattern in code also consider using a branch from your fork for PRs otherwise changes mess up with fork for next PRs.

@pi0 pi0 merged commit 3bb7498 into nitrojs:main Jun 13, 2025
1 check passed
@pi0
Copy link
Member

pi0 commented Jun 13, 2025

/cc @danielroe i think i made same mistake on nuxi-cli for polyfill. It works by coincidence because there is shared crypto.random* and crypto.webcrypto.random* !

danielroe added a commit to nuxt/cli that referenced this pull request Jun 15, 2025
yamanoku pushed a commit to yamanoku/nitro that referenced this pull request Sep 12, 2025
Co-authored-by: Pooya Parsa <pooya@pi0.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants