fix: correctly polyfill globalThis.crypto#3402
Merged
pi0 merged 2 commits intonitrojs:mainfrom Jun 13, 2025
Merged
Conversation
globalThis.crypto
pi0
approved these changes
Jun 13, 2025
Member
pi0
left a comment
There was a problem hiding this comment.
Thanks ❤️
Small tip: Always search for pattern in code also consider using a branch from your fork for PRs otherwise changes mess up with fork for next PRs.
Member
|
/cc @danielroe i think i made same mistake on nuxi-cli for polyfill. It works by coincidence because there is shared |
danielroe
added a commit
to nuxt/cli
that referenced
this pull request
Jun 15, 2025
yamanoku
pushed a commit
to yamanoku/nitro
that referenced
this pull request
Sep 12, 2025
Co-authored-by: Pooya Parsa <pooya@pi0.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist