Skip to content

fix(cloudflare): update command#3473

Closed
gxres042 wants to merge 1 commit intonitrojs:v2from
gxres042:cf-pages-command-fix-v2
Closed

fix(cloudflare): update command#3473
gxres042 wants to merge 1 commit intonitrojs:v2from
gxres042:cf-pages-command-fix-v2

Conversation

@gxres042
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

\

Resolves #3452

Wrangler CLI explicitly requires an output directory for pages dev / deploy (i.e. the directory where Cloudflare Pages should host static assets), so {{ output.dir }} is added to the relevant instructions.

I'm not sure if this is correct.

This PR first attempts to fix the problem on v2, and after merging, a PR will be filed for the v3 version.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@gxres042 gxres042 requested a review from pi0 as a code owner July 14, 2025 12:47
@pi0 pi0 changed the title fix command fix(cloudflare): update command Jul 14, 2025
@pi0
Copy link
Member

pi0 commented Jul 14, 2025

Thank you for PR ❤️

The command is updated to match with expectations of the new cloudflare: { deployConfig: true } behavior, which is expected to be the default.

Closing as it is dup of #3388

@pi0 pi0 closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants