fix(cloudflare): update command#3473
Closed
gxres042 wants to merge 1 commit intonitrojs:v2from
gxres042:cf-pages-command-fix-v2
Closed
fix(cloudflare): update command#3473gxres042 wants to merge 1 commit intonitrojs:v2from gxres042:cf-pages-command-fix-v2
gxres042 wants to merge 1 commit intonitrojs:v2from
gxres042:cf-pages-command-fix-v2
Conversation
Member
|
Thank you for PR ❤️ The command is updated to match with expectations of the new Closing as it is dup of #3388 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
\Resolves #3452
Wrangler CLI explicitly requires an output directory for pages dev / deploy (i.e. the directory where Cloudflare Pages should host static assets), so {{ output.dir }} is added to the relevant instructions.
I'm not sure if this is correct.
This PR first attempts to fix the problem on v2, and after merging, a PR will be filed for the v3 version.
📝 Checklist