fix(vercel): always add url to src regex for isr routes#3595
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pi0
changed the title
url to isr routes src
pi0
changed the title
url to isr routes srcurl to src egex for isr routes
pi0
changed the title
url to src egex for isr routesurl to src regex for isr routes
Member
Author
|
Fix is released in nitropack@2.12.7 |
|
I updated nitropack to version 2.12.7 (double checked in my package-lock.json) but for me the issue still persists. |
Member
Author
|
@ps-20x would you please open a new issue with reproduction so we can track and investigate 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves nuxt/nuxt#33316
In nitro 2.12.6, we have introduced fixes for overlapping route rule functions + better names.
This revealed an undicovered issue where in past ISR route for
/pathwould generate a function called/path.funcand even without ISR path rewrites ($urlparam) it was working as name of function and path were same.This PR fixes issue by 1) always normalizing rou3 patterns to PCRE and 2) Always wrapping regex with
$urlmatcher.