Skip to content

Conversation

@schiller-manuel
Copy link
Contributor

No description provided.

@schiller-manuel schiller-manuel requested a review from pi0 as a code owner December 30, 2025 13:22
@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nitro.build Ready Ready Preview, Comment Dec 30, 2025 1:24pm

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The change adds a port availability wait mechanism to the preview server initialization in the Vite build configuration, importing waitForPort from the get-port-please library and invoking it with 20 retries and 500ms delay after server setup.

Changes

Cohort / File(s) Summary
Preview server port waiting
src/build/vite/preview.ts
Imports waitForPort from get-port-please alongside existing getRandomPort import; adds port availability check after server initialization with 20 retries and 500ms delay

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-preview-wait-for-port

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eecf725 and 8f70560.

📒 Files selected for processing (1)
  • src/build/vite/preview.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pi0 pi0 changed the title fix: vite preview waits for child server to be ready before returning fix(vite): wait on preview child port to be ready Dec 30, 2025
@pi0 pi0 merged commit 74f2198 into main Dec 30, 2025
6 of 9 checks passed
@pi0 pi0 deleted the fix-preview-wait-for-port branch December 30, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants