Add getrlimit(2) and setrlimit(2) #1190
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Mar 19, 2020
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
You also need to fix the segfaults, of course. I'll try to come back and more fully review this at another time,when I'm more rested.
| //! Configure the process resource limits. | ||
| use std::mem; | ||
|
|
||
| #[cfg(not(any(target_os = "freebsd", target_os = "openbsd", target_os = "netbsd", target_os = "macos")))] |
Member
There was a problem hiding this comment.
You shouldn't use a negative config check here. Nix could add a new platform at any time, and it's easier to maintain checks like this if they're all written as positive checks.
|
|
||
| /// Get the current processes resource limits | ||
| /// | ||
| /// A value of None indicates that there's no limit. |
Member
|
Superseded by #1302 |
bors bot
added a commit
that referenced
this pull request
Aug 1, 2021
1302: Add getrlimit and setrlimit r=asomers a=LMJW This PR is based on the previous PR #1190, which has not been updated for a very long time. I have fixed the segfault and compilation error of the original PR and rebased the changes to the latest master branch. Please let me know if anything need to been changed. Co-authored-by: LMJW <heysuperming@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #879. I've added comments and removed usage of the now-deprecated std::mem::uninitialized() function.