Recent versions of Android support EPOLLEXCLUSIVE #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I need to update the changelog, but that is effectively blocked on #1498 since a new section is required. |
Member
|
LGTM. Go ahead and add the CHANGELOG section. We don't need to wait for #1498 to merge this; it won't cause a bad merge collision. |
rtzoeller
added a commit
to rtzoeller/nix
that referenced
this pull request
Oct 16, 2021
Member
|
Looks good. Would you mind squashing your commits? |
rtzoeller
force-pushed
the
epoll_android
branch
from
1b691ba to
6078479
Compare
Collaborator
Author
Done. |
asomers
approved these changes
Oct 16, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Looks good. But let's delay merging until after the 0.23.1 PRs.
Member
|
@rtzoeller needs a rebase |
Enable epoll tests on Android, because they are passing.
rtzoeller
force-pushed
the
epoll_android
branch
from
6078479 to
e5af884
Compare
Collaborator
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding libc change.
Enable the epoll tests on Android, because they are passing.