pidfd_getfd, pid_open and pidfd_send_signal
#1868
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
force-pushed
the
pidfd
branch
3 times, most recently
from
7d5d764 to
59b7a6d
Compare
JonathanWoollett-Light
force-pushed
the
pidfd
branch
from
59b7a6d to
d716424
Compare
JonathanWoollett-Light
force-pushed
the
pidfd
branch
from
d716424 to
31afa82
Compare
bors bot
added a commit
that referenced
this pull request
Dec 11, 2022
1923: feat: I/O safety for 'sys/wait' r=asomers a=SteveLauC
#### What this PR does:
1. Adds I/O safety for `sys/wait`
----------
Actually, I am not sure about which type to use here:
```rust
pub enum Id<'fd> {
/// Wait for the child referred to by the given PID file descriptor
#[cfg(any(target_os = "android", target_os = "linux"))]
PIDFd(RawFd),
PIDFd(BorrowedFd<'fd>),
}
```
If we use `Fd: AsFd`
```rust
pub enum Id<'fd, Fd: AsFd> {
/// Wait for the child referred to by the given PID file descriptor
#[cfg(any(target_os = "android", target_os = "linux"))]
PIDFd(RawFd),
PIDFd(&'fd Fd),
}
```
then the user has to specify that generic type when using this interface, which is kinda user-unfriendly...
------
The typical usage of this interface will be something like:
```rust
// Thought currently we don't have pidfd_open(2) in `Nix`
let fd_referring_to_a_process: OwnedFd = pidfd_open().unwrap();
let status = waitid(Id::PIDFd(fd_referring_to_a_process), WaitPidFlag::XXXX).unwrap();
```
UPDATE: `pidfd_open(2)` will be added in #1859 or #1868 .
Co-authored-by: Steve Lau <stevelauc@outlook.com>
JonathanWoollett-Light
force-pushed
the
pidfd
branch
2 times, most recently
from
4ac9742 to
13f6608
Compare
JonathanWoollett-Light
force-pushed
the
pidfd
branch
4 times, most recently
from
e82740f to
614a2b4
Compare
JonathanWoollett-Light
force-pushed
the
pidfd
branch
from
614a2b4 to
cfd127a
Compare
Merged
bors bot
added a commit
that referenced
this pull request
Jan 11, 2023
1962: fix: Update libc r=asomers a=JonathanWoollett-Light To include fix rust-lang/libc@44cc30c. This is needed to unblock #1868. Co-authored-by: Jonathan <jonathanwoollettlight@gmail.com>
JonathanWoollett-Light
force-pushed
the
pidfd
branch
from
cfd127a to
1df8bfa
Compare
oxalica
suggested changes
Jan 19, 2023
oxalica
left a comment
oxalica
left a comment
There was a problem hiding this comment.
My previous PR contains more tests. It would be good to cherry-pick some here.
src/sys/mod.rs
Outdated
| } | ||
|
|
||
| #[cfg(all(target_os = "linux", feature = "signal", feature = "process"))] | ||
| /// pidfd related functionality |
There was a problem hiding this comment.
This mod is public. I think it's better to have a capitalized description inside src/sys/pidfd.rs instead, to align with other mods like memfd.
Contributor
Author
There was a problem hiding this comment.
Sounds good, fixed.
| // Wait for SIGUSR1 | ||
| let mut mask = SigSet::empty(); | ||
| mask.add(Signal::SIGUSR1); | ||
| assert_eq!(mask.wait().unwrap(), Signal::SIGUSR1); |
There was a problem hiding this comment.
The assertion is done in child process. So even if it fails, the main process would still succeed, which is not what we want.
Contributor
Author
There was a problem hiding this comment.
So the parent needs to assert on the exit code of the child process? How would you suggest doing this?
JonathanWoollett-Light
force-pushed
the
pidfd
branch
2 times, most recently
from
50c0c72 to
50e4eab
Compare
JonathanWoollett-Light
force-pushed
the
pidfd
branch
from
50e4eab to
5367d1a
Compare
JonathanWoollett-Light
force-pushed
the
pidfd
branch
from
5367d1a to
c2ac564
Compare
JonathanWoollett-Light
force-pushed
the
pidfd
branch
from
c2ac564 to
3d29e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
pidfd_getfd,pid_openandpidfd_send_signal.It seems
PIDFD_NONBLOCKis missing fromlibconmusltoolchains: rust-lang/libc#3002.Previously blocked on #1962, rust-lang/libc#3012 and rust-lang/libc#3026.