refactor: cfg for test/* #2230
Merged
refactor: cfg for test/* #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
asomers
approved these changes
Dec 3, 2023
test/sys/mod.rs
Outdated
| target_os = "netbsd", | ||
| target_os = "openbsd" | ||
| ))] | ||
| #[cfg(any(linux_android, freebsdlike, netbsdlike, target_os = "macos"))] |
Member
There was a problem hiding this comment.
This is a candidate for apple_targets. I think ptrace defines all the same symbols for ios etc as for macos.
SteveLauC
force-pushed
the
cfg_for_test
branch
from
94be93c to
79da01d
Compare
Member
Author
done |
Member
Needs another. |
SteveLauC
force-pushed
the
cfg_for_test
branch
from
79da01d to
0b2e61c
Compare
SteveLauC
commented
Dec 9, 2023
| apple_targets, | ||
| target_os = "netbsd", | ||
| target_os = "openbsd", | ||
| target_os = "solaris"))] { |
Member
Author
There was a problem hiding this comment.
Here we have both solarish and target_os = "solarish", this was accidentially introduced in #2248, in case you are curious about the reason
Member
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
cfg for test/*.rs
This PR also applies the
netbsdlikealias added in #2226Checklist:
CONTRIBUTING.md