Skip to content

Conversation

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Sep 4, 2017

No description provided.

@Susurrus
Copy link
Contributor

Susurrus commented Sep 4, 2017

@Mic92 good catch! This LGTM, but I wanted to ask if you could fix the temp folder name for the test_fstatat function to be different from the above test as well. Looks like a copy/paste error when it was added. Once that's done here, I'm r+.

@Mic92
Copy link
Contributor Author

Mic92 commented Sep 4, 2017

Changed via the github web editor (which is also writeable as reviewer).

@Susurrus
Copy link
Contributor

Susurrus commented Sep 5, 2017

@Mic92 Thanks for adding that.

Alright, this is minor and looks fine to me.

bors r+

bors bot added a commit that referenced this pull request Sep 5, 2017
762: test/test_stat.rs: test correct stat function r=Susurrus a=Mic92
@bors
Copy link
Contributor

bors bot commented Sep 5, 2017

Timed out

@asomers
Copy link
Member

asomers commented Sep 7, 2017

Again, the timeout was due to the submitter's umlaut. I'll manually merge it.

@asomers asomers merged commit 5c03196 into nix-rust:master Sep 7, 2017
@Mic92 Mic92 deleted the stat-tests branch September 7, 2017 08:17
@Mic92
Copy link
Contributor Author

Mic92 commented Sep 7, 2017

python and unicode..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants