-
Notifications
You must be signed in to change notification settings - Fork 0
[BE] BackendのGitHubActions作成 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Backend用のGitHub Actions CI環境を構築し、併せてWebSocketクライアントのエラーハンドリング改善やコードクリーンアップを実施しました。
- Backend CI/CD パイプラインの構築(Go lint、format、build)
- WebSocketクライアントの接続安定性向上とエラーハンドリング強化
- DynamoDBテーブル名のハードコード削除と環境変数対応
Reviewed Changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/backend-ci.yml |
Go 1.24.4を使用したCI/CDパイプライン新規作成 |
server/src/internal/feature/quiz/websocket/client.go |
WebSocket接続のエラーハンドリング強化とデッドライン設定の安全化 |
server/src/internal/feature/quiz/websocket/hub.go |
ホスト判定ロジックの改善と変数宣言スタイル統一 |
server/src/internal/database/database.go |
DynamoDBテーブル名のハードコード削除とimport順序修正 |
server/src/internal/feature/quiz/service/quizService.go |
未使用関数の削除と空行整理 |
| その他 | import順序統一と不要な空行削除のマイナークリーンアップ |
📝 変更内容
何を変更したか
backend用のGithubActionsの作成
なぜ変更したか
CI環境の作成のため
🧪 テスト・確認項目
動作確認
📸 スクリーンショット(UI変更がある場合)
💡 補足事項
🔗 関連Issue
Closes #
Note
Adds a backend CI workflow (lint/format/build) and improves server websocket cleanup/error handling while fixing DynamoDB table config to honor env var.
Server CIworkflow.github/workflows/backend-ci.ymlfor PRs touchingserver/**: setup Go1.24.4, rungolangci-lint, enforcegofmt, and buildserver/src/cmd/route/main.go.NewDBConnectionnow honorsDYNAMO_TABLEenv with default"quiz"(removed hard-coded override).ReadPump/WritePump.unregisterClientflow (host detection, room close broadcast, conditional room deletion, cleanup of client send channels).getRandomQuestion.Written by Cursor Bugbot for commit e7ad2ac. This will update automatically on new commits. Configure here.