support cmake package config file : find_package support + auto-install #123
Closed
daminetreg wants to merge 2 commits intonlohmann:masterfrom
Closed
support cmake package config file : find_package support + auto-install #123daminetreg wants to merge 2 commits intonlohmann:masterfrom
daminetreg wants to merge 2 commits intonlohmann:masterfrom
Conversation
Author
|
Is there any chances that this get merged ? 😄 |
Owner
|
Hi Damien, I'll check on the weekend. Cheers, Von meinem iPhone gesendet
|
Author
|
Is there anything I can do to help this get merged ? |
Owner
|
Sorry for not answering... I'm on holiday right now. I'll check when I come back. |
Author
|
No problem 😄 I just wanted to notify that I can change anything/everything if you want/need it. I saw there is a test run error on AppVeyor but I cannot explain it. Is it because I need to link to a different libc++ or so ? |
Owner
|
Please update the PR so the tests on AppVeyor succeed. |
4og
pushed a commit
to eclipse-score/nlohmann_json
that referenced
this pull request
Nov 12, 2025
* update forking instructions * add release management guide * add codeowners
4og
pushed a commit
to eclipse-score/nlohmann_json
that referenced
this pull request
Nov 13, 2025
* update forking instructions * add release management guide * add codeowners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @nlohmann,
I wish to submit you these changes which adds the possibility for dependent programs of your library to use it easily via cmake
find_package, and therefore auto-download+install viahunter_add_package( i.e. see example cmake )..HunterGate( URL "https://github.com/ruslo/hunter/archive/vUPCOMING.tar.gz" SHA1 "53b198e364dc7bc8360fc545f798563229bd7e20" ) project(dowload-nlohmann-json) hunter_add_package(nlohmann-json) find_package(nlohmann-json) add_executable(main main.cpp) target_link_libraries(main nlohmann-json::nlohmann-json)For the moment this is not in Hunter ( i.e. See PR #239 ), but even if it isn't accepted in Hunter, it is useful for code depending on your library, as the changes aren't Hunter specific, they allow the standard cmake
find_packagemechanism to be used to find your library.Thank you very much for your awesome library to handle json. I like it. 😄
Cheers,