Convert unit testing to use new APIs instead of deprecated ones.#1269
Closed
chuckatkins wants to merge 1 commit intonlohmann:developfrom
Closed
Convert unit testing to use new APIs instead of deprecated ones.#1269chuckatkins wants to merge 1 commit intonlohmann:developfrom
chuckatkins wants to merge 1 commit intonlohmann:developfrom
Conversation
Owner
|
I would still like to test the deprecated functions. |
Contributor
Author
|
Sure thing. I was cleaning up warnings so instead of changing the code here would you be okay with just disabling the deprecation warnings for these files? |
Owner
|
I think we should not change the test suite, but maybe just add flags to suppress the deprecation warnings. On the other hand, I am not too much concerned about these warnings, because in the end they exactly make sense... |
Contributor
Author
|
Closing. Will keep deprecated apis in testing but disable deprecation warnings for these files only in a new pr |
chuckatkins
pushed a commit
to chuckatkins/json
that referenced
this pull request
Oct 2, 2018
In follow up from the conversation in nlohmann#1269, this adds the `-Wno-deprecate-definitions` flag to unit tests to allow them to test deprecated APIs without all the noisy compiler warnings. This also refactors the setting of build properties for test targets to use `target_<...>` commands instead of `set_properties()`.
chuckatkins
pushed a commit
to chuckatkins/json
that referenced
this pull request
Oct 2, 2018
In follow up from the conversation in nlohmann#1269, this adds the `-Wno-deprecate-declarations` flag to unit tests to allow them to test deprecated APIs without all the noisy compiler warnings. This also refactors the setting of build properties for test targets to use `target_<...>` commands instead of `set_properties()`.
chuckatkins
pushed a commit
to chuckatkins/json
that referenced
this pull request
Oct 2, 2018
In follow up from the conversation in nlohmann#1269, this adds the `-Wno-deprecate-declarations` flag to unit tests to allow them to test deprecated APIs without all the noisy compiler warnings. This also refactors the setting of build properties for test targets to use `target_<...>` commands instead of `set_target_properties()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests were still using deprecated APIs causing a lot of noise during compilation. This converts the unit tets to use the new APIs for iterators and stream operators.