Fix json.hpp compilation issue with other typedefs with same name (Issue #1642)

[kevinlul]

While in our case, only the string case was affected, to be safe and allow the library to work with other unforeseen cases, all of the cases have been wrapped with parentheses.

Thank you @DyXel and @edo9300

Fixes #1642

---

Pull request checklist

Read the Contribution Guidelines for detailed information.

• Changes are described in the pull request, or an existing issue is referenced.
• The test suite compiles and runs without error.
• Code coverage is 100%. Test cases can be added by editing the test suite.
• The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

[coveralls]

Coverage remained the same at 100.0% when pulling e616d09 on kevinlul:develop into 4fc98e0 on nlohmann:develop.

[nlohmann]

Can we also add a regression test?

[kevinlul]

Do you mean adding a test case to tests/ for this behaviour?

[nlohmann]

Yes. Best to unit-regression.cpp if this is possible.

[nlohmann]

@kevinlul Let me know if you need help on the test case.

[kevinlul]

It seems like boolean is already a definition somewhere under VS2015, including Windows headers?

[nlohmann]

Indeed - the error only occurs in the configuration where we include windows.h to detect exactly these kind of issues... I think it would be best not to mention boolean in the regression test.

[nlohmann]

Thanks!

[nlohmann]

---

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

• ✨ New Feature
• 🐛 Bug Fix
• ⚡️ Improvement
• 🔨 Further Change
• 🔥 Deprecated function

Description

• Fixed an issue where typedefs with certain names yielded a compilation error json.hpp compilation issue with other typedefs with same name #1642.

---