make CMake's version config file architecture-independent#1746
make CMake's version config file architecture-independent#1746nlohmann merged 2 commits intonlohmann:developfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@nlohmann can you re-open this please (or even better, merge it. ;) ) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
nlohmann
left a comment
There was a problem hiding this comment.
Sorry for the long delay. It would be great if you could address my comments, then this issue would be finally fixed.
|
I've added comments as requested. |
|
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Fixes #1697. In short, CMake's
write_basic_package_version_fileby default creates a file that checks whether it is being called on a 32- or 64-bit architecture, and will fail if it is called on a different bit size than what it was built on, even though that doesn't affect the JSON library, since it is header-only. This replaces the automatically-generated file with a file that checks the version requirement, but does not check the word size. (It is essentially CMake's file, but with the word size check removed.)