Merged
Conversation
binary_reader.hpp:650: (style) Unsigned expression 'mant' can't be negative so it is unnecessary to test it https://github.com/Xav83/nlohmann-json-cppcheck/commit/910a7d2b873dd7ae92ec81cced2bf73200ff4848/checks#step:5:84 Signed-off-by: Xav83 <x.jouvenot@gmail.com>
Xav83
force-pushed
the
cppcheckFixes
branch
from
708b16a to
1667541
Compare
jaredgrubb
reviewed
Sep 20, 2019
Xav83
force-pushed
the
cppcheckFixes
branch
2 times, most recently
from
d43728f to
0605a2e
Compare
binary_writer.hpp:869: (style) Consider using std::accumulate algorithm instead of a raw loop. https://github.com/Xav83/nlohmann-json-cppcheck/commit/910a7d2b873dd7ae92ec81cced2bf73200ff4848/checks#step:5:107 Signed-off-by: Xav83 <x.jouvenot@gmail.com>
Xav83
force-pushed
the
cppcheckFixes
branch
from
0605a2e to
87afee1
Compare
Contributor
Author
|
I don't understand why the Travis job with Xcode 9.3 fails, but I found a ninja issue similar to the error message. And errors found by Code Inspector aren't referencing the code I modified. So, should I fix them or should they be fixed in another Pull Request ? |
nlohmann
added
release item: ⚡ improvement
release item: 🔨 further change
and removed
release item: ⚡ improvement
labels
Owner
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request corrects two of the warnings reported by cppcheck, mentionned in #1759
A warning about an unnecessary check in the first commit, and a warning about a code enhancement in the second warning, by using the std::accumulate function instead of a raw loop.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filesingle_include/nlohmann/json.hpp. The whole process is described here.Please don't
#ifdefs or other means.