Improve parse_ubjson_fuzzer#2182
Merged
nlohmann merged 1 commit intonlohmann:developfrom Jun 12, 2020
tanuj208:develop
Merged
Conversation
Owner
|
Thanks, the changes look good. I'll merge once the CI runs through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in parse_ubjson_fuzzer, the method json::to_ubjson() was called with default values to the arguments use_size and use_type. I went through the coverage data and found out that there were many lines of code that could be covered if provided other combinations of values to them.
So, I added code with changing the values to these arguments and compared the resulting vectors. By doing this coverage went up by
Line coverage = ~240 lines
Functional coverage = 18 functions
Region coverage = ~90 regions
Coverage report
Let me know if there is an incorrect use of the API.