support visual studio compilers (2013 & 2014) on windows#29
support visual studio compilers (2013 & 2014) on windows#29kirkshoop wants to merge 2 commits intonlohmann:masterfrom
Conversation
test/json_unit.cc
Outdated
There was a problem hiding this comment.
replace tabs with spaces
|
.editorconfig has been added to ensure that whitespace is maintained automatically. |
|
is there something more that I need to address? |
|
Hi @kirkshoop, sorry for not answering earlier. Though I like the idea of having a Windows version, I am currently working on new code that uses even more C++11 features. When I look at your code, I see that you mostly use the preprocessor to exclude those parts that are not yet supported by Visual Studio. I think I would rather wait until Visual Studio has true C++11 support rather than to fragmentize the project like this - in the end, I am using this project to learn the new C++11 features. I'm going to close the pull request here, but I would be happy if you would host a Windows-compatible version yourself. I would link to it in the README. |
Sync Fork from Upstream Repo
- Created from nlohmann_json's unit-class_parser.cpp an new test class - Replaced parse_helper and accept_helper with direct json::accept() and json::parse() calls - Simplification ensures test results directly validate accept() and parse() - Enables clear evidence for JSON well-formedness and parsing requirements
4 participants
If you like, login to http://appveyor.com to add windows CI for the json project. the configuration is in appveyor.yml