Skip to content

Extend std specializations#3121

Merged
nlohmann merged 1 commit intodevelopfrom
extend_std_specializations
Nov 4, 2021
Merged

Extend std specializations#3121
nlohmann merged 1 commit intodevelopfrom
extend_std_specializations

Conversation

@nlohmann
Copy link
Owner

@nlohmann nlohmann commented Nov 4, 2021

This PR extends std::hash and std::swap to work on any nlohmann::basic_json specializations rather than just nlohmann::json.

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Nov 4, 2021
@nlohmann nlohmann added this to the Release 3.10.5 milestone Nov 4, 2021
@nlohmann nlohmann self-assigned this Nov 4, 2021
@coveralls
Copy link

coveralls commented Nov 4, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 9abcdae on extend_std_specializations into 5d87c4d on develop.

@nlohmann nlohmann added release item: ⚡ improvement and removed review needed It would be great if someone could review the proposed changes. labels Nov 4, 2021
@nlohmann nlohmann merged commit 5c08a52 into develop Nov 4, 2021
@nlohmann nlohmann deleted the extend_std_specializations branch November 4, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gregmarr gregmarr gregmarr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nlohmann nlohmann

Labels

release item: ⚡ improvement

Projects

None yet

Milestone

Release 3.10.5

Development

Successfully merging this pull request may close these issues.

3 participants

@nlohmann @coveralls @gregmarr