fix _MSC_VER version to check for std::filesystem#3240
Merged
nlohmann merged 1 commit intonlohmann:developfrom Jan 3, 2022
Merged
fix _MSC_VER version to check for std::filesystem#3240nlohmann merged 1 commit intonlohmann:developfrom
nlohmann merged 1 commit intonlohmann:developfrom
Conversation
Owner
|
Thanks for the PR! Looks like a copy/paste error on my side. I will happily merge this if the CI accepts it. I am not using MSVC myself... |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to
json/include/nlohmann/detail/macro_scope.hpp
Line 72 in cc59ab1
std::filesystemsince 19.14, (Visual Studio 2017 version 15.7) that has_MSC_VER == 1914according to Microsoft documentation, but the check is done against a not existing value1940(latest Visual Studio 2022 has_MSC_VER == 1930).I just change this value.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filesingle_include/nlohmann/json.hpp. The whole process is described here.Please don't
#ifdefs or other means.